Nearly every American is now within a few hours’ drive of a casino. But critics note that casino gambling has not delivered on its economic promises.